Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1314643006: Don't use Ahem font in LayoutTests/editing/selection/move-by-line-006.html (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't use Ahem font in LayoutTests/editing/selection/move-by-line-006.html This patch changes "move-by-line-006.html" to use "monospace" font instead of "Ahem" font to mitigate flakiness on local Windows desktop. When I run "move-by-line-006.html" on local Windows desktop, it is flaky, e.g. failed on parallel test execution but succeeded on single execution. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201856

Patch Set 1 : 2015-09-07T10:40:31 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/editing/selection/move-by-line-006.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/editing/selection/move-by-line-006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-07 03:23:47 UTC) #3
hajimehoshi
lgtm
5 years, 3 months ago (2015-09-07 04:54:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314643006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314643006/1
5 years, 3 months ago (2015-09-07 04:55:07 UTC) #6
yoichio
Why expect is changed?
5 years, 3 months ago (2015-09-07 04:57:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201856
5 years, 3 months ago (2015-09-07 04:59:31 UTC) #8
hajimehoshi
5 years, 3 months ago (2015-09-07 05:01:12 UTC) #9
Message was sent while issue was closed.
On 2015/09/07 04:57:44, yoichio wrote:
> Why expect is changed?

I guess that's because the font was changed and the rendered text in a line was
changed.

Powered by Google App Engine
This is Rietveld 408576698