Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314643003: Fix leak in BlinkGCDumpProviderTest.MemoryDump (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Fix leak in BlinkGCDumpProviderTest.MemoryDump BUG=523910, 490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 4 months ago (2015-08-24 20:03:50 UTC) #2
Primiano Tucci (use gerrit)
bleh, memory-infra tests leaking memory. LGTM from the shame cube, thanks for fixing this and ...
5 years, 4 months ago (2015-08-24 21:04:07 UTC) #3
Primiano Tucci (use gerrit)
Ah right, createProcessMemoryDump() is a platform method and returns a rawptr not a OwnPtr, that's ...
5 years, 4 months ago (2015-08-24 21:05:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314643003/1
5 years, 4 months ago (2015-08-24 21:10:56 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 22:19:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201076

Powered by Google App Engine
This is Rietveld 408576698