Plugins: Remove Shadow DOM Plugin Placeholder

Plugins: Remove Shadow DOM Plugin Placeholder

It's not under active development and doesn't support Plugin Power Saver. It's
overall a good approach, but unfortunately Shadow DOM doesn't have a good
mechanism to call into C++ at present.

Plugins themselves will (hopefully) be obsolete by the time it does.

BUG=524115
Committed: https://crrev.com/0c85f0c129bd64e6f3e5aabb659621d8cf65c690
Cr-Commit-Position: refs/heads/master@{#345496}

[tommycli, 2015-08-24 18:13:21]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2015-08-24 18:13:38]

tommycli@chromium.org changed reviewers:
+ jbroman@chromium.org

[tommycli, 2015-08-24 18:13:38]

jbroman: PTAL, let me know if i missed anything in removal

[commit-bot: I haz the power, 2015-08-24 18:14:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314643002/1

[jbroman, 2015-08-24 18:24:14]

Also RenderFrameImpl::createPluginPlaceholder can go away.

Otherwise I think that's it for Chromium-side code.

https://codereview.chromium.org/1314643002/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.h (left):

https://codereview.chromium.org/1314643002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.h:92:
scoped_ptr<blink::WebPluginPlaceholder> CreatePluginPlaceholder(
Please also remove the method this overrides in content::ContentRendererClient.

[commit-bot: I haz the power, 2015-08-24 18:32:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 18:32:25]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tommycli, 2015-08-24 18:39:13]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-24 18:39:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314643002/10010
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314643002/10010

[tommycli, 2015-08-24 20:00:06]

jbroman: thanks!

https://codereview.chromium.org/1314643002/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.h (left):

https://codereview.chromium.org/1314643002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.h:92:
scoped_ptr<blink::WebPluginPlaceholder> CreatePluginPlaceholder(
On 2015/08/24 18:24:14, jbroman wrote:
> Please also remove the method this overrides in
content::ContentRendererClient.

Done.

[commit-bot: I haz the power, 2015-08-24 20:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 20:34:56]

Dry run: This issue passed the CQ dry run.

[tommycli, 2015-08-24 21:54:33]

Patchset #3 (id:30001) has been deleted

[tommycli, 2015-08-25 16:45:23]

jbroman: ptal, thanks, this is the chromium-side patch.

[jbroman, 2015-08-25 16:53:19]

lgtm

[tommycli, 2015-08-25 17:07:34]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-08-25 17:07:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1314643002/#ps70001
(title: " ")

[commit-bot: I haz the power, 2015-08-25 17:08:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314643002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314643002/70001

[commit-bot: I haz the power, 2015-08-25 17:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 17:19:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbroman, 2015-08-25 17:21:03]

On 2015/08/25 at 17:19:11, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Oh sorry, you'll still need a covering set of OWNERS. I own nothing. :)

[tommycli, 2015-08-25 17:21:35]

tommycli@chromium.org changed reviewers:
+ kinuko@chromium.org, sky@chromium.org

[tommycli, 2015-08-25 17:21:35]

sky: PTAL chrome & components review please
kinuko: PTAL content review please

thanks! This is just a straight code removal patch.

[tommycli, 2015-08-25 17:22:09]

On 2015/08/25 17:21:03, jbroman wrote:
> On 2015/08/25 at 17:19:11, commit-bot wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Oh sorry, you'll still need a covering set of OWNERS. I own nothing. :)

No problem. I forgot to check the OWNERs files :)

[sky, 2015-08-25 21:06:14]

LGTM

[kinuko, 2015-08-25 23:55:49]

lgtm

[tommycli, 2015-08-26 00:07:58]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-08-26 00:08:03]

all: thank you!

[commit-bot: I haz the power, 2015-08-26 00:08:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314643002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314643002/70001

[commit-bot: I haz the power, 2015-08-26 00:14:28]

Committed patchset #4 (id:70001)

[commit-bot: I haz the power, 2015-08-26 00:15:06]

Patchset 4 (id:??) landed as
https://crrev.com/0c85f0c129bd64e6f3e5aabb659621d8cf65c690
Cr-Commit-Position: refs/heads/master@{#345496}

[dstockwell, 2015-08-26 01:34:48]

A revert of this CL (patchset #4 id:70001) has been created in
https://codereview.chromium.org/1319543004/ by dstockwell@chromium.org.

The reason for reverting is: Caused several blink layout and unit tests to fail:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/5...

unit tests failures:
PluginPlaceholderImplTest.MessageIsShown
PluginPlaceholderImplTest.NotCloseable
PluginPlaceholderImplTest.MessageDoesNotRunScripts
FrameLoaderClientImplTest.CreatePluginPlaceholderForwardsToWebFrameClient
PluginPlaceholderImplTest.MessageDoesNotAcceptElements
PluginPlaceholderImplTest.Closeable

layout test unexpected_failures:
fast/plugins/plugin-placeholder-structured.html
fast/plugins/plugin-placeholder-close.html
fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash.html
fast/plugins/plugin-placeholder-inherit.html
fast/plugins/plugin-placeholder-csp.html
fast/plugins/plugin-placeholder-focus.html.

[jbroman, 2015-08-26 14:12:18]

On 2015/08/26 at 01:34:48, dstockwell wrote:
> A revert of this CL (patchset #4 id:70001) has been created in
https://codereview.chromium.org/1319543004/ by dstockwell@chromium.org.
> 
> The reason for reverting is: Caused several blink layout and unit tests to
fail:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/5...
> 
> unit tests failures:
> PluginPlaceholderImplTest.MessageIsShown
> PluginPlaceholderImplTest.NotCloseable
> PluginPlaceholderImplTest.MessageDoesNotRunScripts
> FrameLoaderClientImplTest.CreatePluginPlaceholderForwardsToWebFrameClient
> PluginPlaceholderImplTest.MessageDoesNotAcceptElements
> PluginPlaceholderImplTest.Closeable
> 
> layout test unexpected_failures:
> fast/plugins/plugin-placeholder-structured.html
> fast/plugins/plugin-placeholder-close.html
> fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash.html
> fast/plugins/plugin-placeholder-inherit.html
> fast/plugins/plugin-placeholder-csp.html
> fast/plugins/plugin-placeholder-focus.html.

Whoops; looks like you might have to remove the plugin placeholder tests in
Blink first. Unfortunately,
remove-shadowroot-from-document-and-destroy-crash.html looks like it may have to
be rewritten to not use shadow DOM plugin placeholders as its test case (it
seems to have been added by someone else).