Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 131463006: Add third-party library 'webtreemap' for use in tools. (Closed)

Created:
6 years, 11 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 11 months ago
Reviewers:
Daniel Berlin, Torne, cpu_(ooo_6.6-7.5), jschuh, open-source-third-party-reviews, security, bulach
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add third-party library 'webtreemap' for use in tools. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245353

Patch Set 1 #

Patch Set 2 : Remove miguelg, add bulach at their request #

Patch Set 3 : Delete demo directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -1 line) Patch
A + third_party/webtreemap/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/webtreemap/README.chromium View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A + third_party/webtreemap/src/COPYING View 1 2 1 chunk +1 line, -1 line 0 comments Download
A third_party/webtreemap/src/README.markdown View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/webtreemap/src/webtreemap.css View 1 2 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/webtreemap/src/webtreemap.js View 1 2 1 chunk +232 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Andrew Hayden (chromium.org)
6 years, 11 months ago (2014-01-13 08:59:20 UTC) #1
jschuh
lgtm for security
6 years, 11 months ago (2014-01-13 14:39:43 UTC) #2
Daniel Berlin
LGTM for open-source-third-party-reviews
6 years, 11 months ago (2014-01-15 16:33:39 UTC) #3
Andrew Hayden (chromium.org)
+cpu@ as an owner of src/third_party, so we can get this checked in and unblock ...
6 years, 11 months ago (2014-01-16 11:23:17 UTC) #4
Andrew Hayden (chromium.org)
Removed miguelg@ as owner, added bulach@. Also, I deleted the demo directory (which we don't ...
6 years, 11 months ago (2014-01-16 13:32:17 UTC) #5
bulach
lgtm, thanks!
6 years, 11 months ago (2014-01-16 13:34:53 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
6 years, 11 months ago (2014-01-16 18:51:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/131463006/360001
6 years, 11 months ago (2014-01-16 20:30:10 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 22:25:26 UTC) #9
Message was sent while issue was closed.
Change committed as 245353

Powered by Google App Engine
This is Rietveld 408576698