Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 131463005: kiosk: Show network screen for interrupted enrollment. (Closed)

Created:
6 years, 11 months ago by xiyuan
Modified:
6 years, 11 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, zel
Visibility:
Public.

Description

kiosk: Show network screen for interrupted enrollment. http://crbug.com/322666 makes enrollment screen to be the first screen for an interrupted auto start enrollment flow (remora). But the enrollment screen does not handle flaky network well and often lands user in a network error page. This CL makes the interrupted flow resumes from network screen. BUG=332572 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_ui_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
6 years, 11 months ago (2014-01-09 23:23:37 UTC) #1
Tim Song
lgtm
6 years, 11 months ago (2014-01-09 23:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/131463005/1
6 years, 11 months ago (2014-01-10 05:54:06 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 07:11:55 UTC) #4
Message was sent while issue was closed.
Change committed as 244115

Powered by Google App Engine
This is Rietveld 408576698