Move TranslateURLFetcher to the translate component

Move TranslateURLFetcher to the translate component

This CL introduces the TranslateDelegate to inject the required
dependencies in the translate component.
TranslateDelegate is a singleton for now, but this will need to be
revisited once the ownership model of TranslateManager is improved.

BUG=331509
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244199

[blundell, 2014-01-09 12:14:17]

Mostly nits.

https://codereview.chromium.org/131463002/diff/60001/chrome/browser/translate...
File chrome/browser/translate/translate_delegate_impl.h (right):

https://codereview.chromium.org/131463002/diff/60001/chrome/browser/translate...
chrome/browser/translate/translate_delegate_impl.h:20: class
TranslateDelegateImpl : public TranslateDelegate {
It would be more conventional to name this class ChromeTranslateDelegate.

https://codereview.chromium.org/131463002/diff/60001/chrome/browser/translate...
chrome/browser/translate/translate_delegate_impl.h:20: class
TranslateDelegateImpl : public TranslateDelegate {
Should have a class comment.

https://codereview.chromium.org/131463002/diff/60001/components/translate/cor...
File components/translate/core/browser/translate_delegate.h (right):

https://codereview.chromium.org/131463002/diff/60001/components/translate/cor...
components/translate/core/browser/translate_delegate.h:17: // Returns the URL
request context information associated with this driver.
"Returns the URL request context in which the Translate component should make
requests."

https://codereview.chromium.org/131463002/diff/60001/components/translate/cor...
File components/translate/core/browser/translate_url_fetcher.h (right):

https://codereview.chromium.org/131463002/diff/60001/components/translate/cor...
components/translate/core/browser/translate_url_fetcher.h:28: explicit
TranslateURLFetcher(int id, TranslateDelegate* delegate);
Document lifetime assumption of the passed-in pointer.

https://codereview.chromium.org/131463002/diff/60001/components/translate/cor...
components/translate/core/browser/translate_url_fetcher.h:64: TranslateDelegate*
translate_delegate_;
Needs a comment.

[droger, 2014-01-09 17:41:49]

Thanks for the review.

+mad as OWNER

[droger, 2014-01-09 18:10:07]

+cbentzel as OWNER for the addition of net/ in components/translate/DEPS

[droger, 2014-01-09 18:10:22]

+cbentzel as OWNER for the addition of net/ in components/translate/DEPS

[MAD, 2014-01-09 22:04:34]

LGMT...

[cbentzel, 2014-01-09 22:05:49]

LGTM for net dependency,

[MAD, 2014-01-09 22:06:34]

Oupsss... LGTM not LGMT ;-)

[commit-bot: I haz the power, 2014-01-09 22:33:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/131463002/200001

[commit-bot: I haz the power, 2014-01-09 22:33:50]

Failed to apply patch for chrome/browser/translate/translate_language_list.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/translate/translate_language_list.cc
  Hunk #1 FAILED at 14.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/translate/translate_language_list.cc.rej

Patch:       chrome/browser/translate/translate_language_list.cc
Index: chrome/browser/translate/translate_language_list.cc
diff --git a/chrome/browser/translate/translate_language_list.cc
b/chrome/browser/translate/translate_language_list.cc
index
29fb947358e84576fe1685eec18ea048435d551c..de324d8198942286ccc65580512a91438fb7aaf7
100644
--- a/chrome/browser/translate/translate_language_list.cc
+++ b/chrome/browser/translate/translate_language_list.cc
@@ -14,11 +14,12 @@
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/translate/chrome_translate_delegate.h"
 #include "chrome/browser/translate/translate_browser_metrics.h"
 #include "chrome/browser/translate/translate_manager.h"
-#include "chrome/browser/translate/translate_url_fetcher.h"
 #include "chrome/browser/translate/translate_url_util.h"
 #include "components/translate/core/browser/translate_event_details.h"
+#include "components/translate/core/browser/translate_url_fetcher.h"
 #include "net/base/url_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
@@ -226,7 +227,8 @@ TranslateLanguageList::TranslateLanguageList() {
   if (update_is_disabled)
     return;
 
-  language_list_fetcher_.reset(new TranslateURLFetcher(kFetcherId));
+  language_list_fetcher_.reset(new TranslateURLFetcher(
+      kFetcherId, ChromeTranslateDelegate::GetInstance()));
   language_list_fetcher_->set_max_retry_on_5xx(kMaxRetryOn5xx);
 }

[commit-bot: I haz the power, 2014-01-10 11:54:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/131463002/330001

[commit-bot: I haz the power, 2014-01-10 12:43:31]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-10 14:33:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/131463002/660001

[commit-bot: I haz the power, 2014-01-10 17:59:54]

Change committed as 244199