Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1314613002: Drop LayoutVTTCue::adjustForTopAndBottomMarginBorderAndPadding (Closed)

Created:
5 years, 4 months ago by fs
Modified:
5 years, 4 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Drop LayoutVTTCue::adjustForTopAndBottomMarginBorderAndPadding This method only serves to break the cue layout computed by SnapToLinesLayouter. If we want to factor in margin+border for cues (and padding for the cue container), then factor that into the cue layout algorithm instead. BUG=301580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201119

Patch Set 1 #

Patch Set 2 : Drop seagulls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M Source/core/layout/LayoutVTTCue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutVTTCue.cpp View 1 2 chunks +2 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
My recollection says that we discussed (the usefulness of) this method at some point (authoring ...
5 years, 4 months ago (2015-08-24 13:09:37 UTC) #2
philipj_slow
lgtm
5 years, 4 months ago (2015-08-25 10:06:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314613002/20001
5 years, 4 months ago (2015-08-25 10:07:09 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 10:11:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201119

Powered by Google App Engine
This is Rietveld 408576698