Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1314603002: Revert of Version 4.5.103.23 (cherry-pick) (Closed)

Created:
5 years, 4 months ago by Michael Hablich
Modified:
5 years, 4 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.5
Target Ref:
refs/pending/branch-heads/4.5
Project:
v8
Visibility:
Public.

Description

Revert of Version 4.5.103.23 (cherry-pick) (patchset #1 id:1 of https://codereview.chromium.org/1297153002/ ) Reason for revert: One of the merged CLs is the culprit for https://code.google.com/p/chromium/issues/detail?id=519319. Original issue's description: > Version 4.5.103.23 (cherry-pick) > > Merged 0752abb11453a3f1ea1d4eecf3f9068b6f599e4d > Merged b528d0772bba9bc378c9cc18f624513ccfc7f8e8 > Merged 869ab06ea5165ce0dc01396150a110478f8a3e42 > Merged 9d7ebcf7f508b987464575b481476ce0a49d98b1 > Merged da97af0d016aa69b78551de6b953f0624e8d6792 > Merged e296644f953f5af906483abaa0965818c5369dd9 > Merged 1345f811bf6a3ab9376cfbed6f08084662b32a4d > > Extract function to compute mutator utilization. > > Use conservative estimate for GC speed instead of bailing out when computing mutator utilization. > > GC: Refactor incremental marking steps w/ deadline into a separate call > > Reland: GC: Refactor public incremental marking interface in heap > > Fix idle step marking after 9d7ebc. > > Partially revert https://crrev.com/7e53749df0a10f475404e86ef0ca8df02bb79e7a > > Make sure that memory reducer makes progress in incremental marking even if there are no idle notifications. > > BUG=chromium:502247, chromium:515873, chromium:517468, chromium:520841 > LOG=N > R=hablich@chromium.org, mlippautz@chromium.org, jkummerow@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/b9b42f9020b693bfa25510a9e1e2c1da57eeb263 R=mlippautz@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:502247, chromium:515873, chromium:517468, chromium:520841, chromium:519319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -211 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/heap/heap.h View 3 chunks +0 lines, -21 lines 0 comments Download
M src/heap/heap.cc View 7 chunks +27 lines, -108 lines 0 comments Download
M src/heap/incremental-marking.h View 4 chunks +1 line, -22 lines 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +4 lines, -20 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +1 line, -24 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
PTAL FYI: Still needs to be tagged after commit.
5 years, 4 months ago (2015-08-24 12:37:52 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-24 13:05:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314603002/1
5 years, 4 months ago (2015-08-24 13:06:46 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 13:07:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698