Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314583003: Replace SkPin32 with SkTPin and remove. (Closed)

Created:
5 years, 3 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace SkPin32 with SkTPin and remove. SkPin32 is already just forwarding to SkTPin, so convert existing users and remove SkPin32. Committed: https://skia.googlesource.com/skia/+/62ce0303fb3f9857ee3ab8df05934642c226b1a3

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M include/core/SkTypes.h View 1 1 chunk +3 lines, -7 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFontStyle.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkTableMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314583003/1
5 years, 3 months ago (2015-08-28 15:29:52 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 15:35:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314583003/20001
5 years, 3 months ago (2015-08-28 15:40:13 UTC) #6
bungeman-skia
5 years, 3 months ago (2015-08-28 15:40:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 15:45:32 UTC) #10
reed1
lgtm
5 years, 3 months ago (2015-08-28 16:02:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314583003/20001
5 years, 3 months ago (2015-08-28 16:08:59 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 16:09:36 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/62ce0303fb3f9857ee3ab8df05934642c226b1a3

Powered by Google App Engine
This is Rietveld 408576698