Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1314553003: Fix Clang style-plugin errors in memory_pressure component (Closed)

Created:
5 years, 4 months ago by hans
Modified:
5 years, 4 months ago
Reviewers:
chrisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Clang style-plugin errors in memory_pressure component From http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/2796/steps/compile/logs/stdio: ..\..\components/memory_pressure/filtered_memory_pressure_calculator.h(31,3) : error: [chromium-style] Complex destructor has an inline body. ~FilteredMemoryPressureCalculator() {} ^ ..\..\components/memory_pressure/filtered_memory_pressure_calculator.h(31,39) : error: [chromium-style] Overriding method must be marked with 'override' or 'final'. ~FilteredMemoryPressureCalculator() {} ^ override ..\..\components/memory_pressure/direct_memory_pressure_calculator.h(41,45) : error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~DirectMemoryPressureCalculator() {} ^ override BUG=82385, 520962 TBR=chrisha Committed: https://chromium.googlesource.com/chromium/src/+/ea3ec1ea7c1ad2ac50f54f50a14b644904f7df02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/memory_pressure/direct_memory_pressure_calculator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_pressure/filtered_memory_pressure_calculator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_pressure/filtered_memory_pressure_calculator.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314553003/1
5 years, 4 months ago (2015-08-24 17:45:31 UTC) #3
hans
Committed patchset #1 (id:1) manually as ea3ec1ea7c1ad2ac50f54f50a14b644904f7df02 (presubmit successful).
5 years, 4 months ago (2015-08-24 18:01:11 UTC) #4
chrisha
5 years, 4 months ago (2015-08-24 18:29:24 UTC) #5
Message was sent while issue was closed.
Thanks for cleaning this up.

lgtm

Powered by Google App Engine
This is Rietveld 408576698