Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_plane.cc

Issue 1314553002: Move Format checks to HardwareDisplayPlane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/hardware_display_plane.cc
diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane.cc b/ui/ozone/platform/drm/gpu/hardware_display_plane.cc
index 3f700cbbcf56702eb7f5de0b9b4aa65b03ac3fc0..b66369aafd233bbb5c2e30440f65a83e1236e9f6 100644
--- a/ui/ozone/platform/drm/gpu/hardware_display_plane.cc
+++ b/ui/ozone/platform/drm/gpu/hardware_display_plane.cc
@@ -56,15 +56,19 @@ bool HardwareDisplayPlane::CanUseForCrtc(uint32_t crtc_index) {
bool HardwareDisplayPlane::Initialize(DrmDevice* drm,
const std::vector<uint32_t>& formats,
- bool is_dummy) {
+ bool is_dummy,
+ bool test_only) {
+ supported_formats_ = formats;
+
+ if (test_only)
+ return true;
+
if (is_dummy) {
type_ = kDummy;
supported_formats_.push_back(DRM_FORMAT_XRGB8888);
return true;
}
- supported_formats_ = formats;
-
ScopedDrmObjectPropertyPtr plane_props(drmModeObjectGetProperties(
drm->get_fd(), plane_id_, DRM_MODE_OBJECT_PLANE));
if (!plane_props) {
@@ -84,8 +88,22 @@ bool HardwareDisplayPlane::Initialize(DrmDevice* drm,
return InitializeProperties(drm, plane_props);
}
-bool HardwareDisplayPlane::IsSupportedFormat(uint32_t format) const {
- return true;
+bool HardwareDisplayPlane::IsSupportedFormat(uint32_t format) {
+ if (!format)
+ return false;
+
+ if (last_used_format_ == format)
+ return true;
+
+ for (auto& element : supported_formats_) {
+ if (element == format) {
+ last_used_format_ = format;
+ return true;
+ }
+ }
+
+ last_used_format_ = 0;
+ return false;
}
bool HardwareDisplayPlane::InitializeProperties(
« no previous file with comments | « ui/ozone/platform/drm/gpu/hardware_display_plane.h ('k') | ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698