Move Format checks to HardwareDisplayPlane

ui/ozone/platform/drm/gpu/hardware_display_plane.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/gpu/hardware_display_plane.h"
 
 #include <drm_fourcc.h>
 
 #include "base/logging.h"
 #include "ui/ozone/platform/drm/gpu/drm_device.h"
@@ skipping 38 matching lines @@
 
 HardwareDisplayPlane::~HardwareDisplayPlane() {
 }
 
 bool HardwareDisplayPlane::CanUseForCrtc(uint32_t crtc_index) {
   return possible_crtcs_ & (1 << crtc_index);
 }
 
 bool HardwareDisplayPlane::Initialize(DrmDevice* drm,
                                       const std::vector<uint32_t>& formats,
-                                      bool is_dummy) {
+                                      bool is_dummy,
+                                      bool test_only) {
+  supported_formats_ = formats;
+
+  if (test_only)
+    return true;
+
   if (is_dummy) {
     type_ = kDummy;
-    supported_formats_.push_back(DRM_FORMAT_XRGB8888);
+    if (supported_formats_.empty())

[dnicoara, 2015/08/27 13:21:56]

Could you just drop this if-statement and pass in DRM_FORMAT_XRGB8888 when the
dummy plane is initialized?

[kalyank, 2015/08/27 16:07:10]

Done.

+      supported_formats_.push_back(DRM_FORMAT_XRGB8888);
+
     return true;
   }
 
-  supported_formats_ = formats;
-
   ScopedDrmObjectPropertyPtr plane_props(drmModeObjectGetProperties(
       drm->get_fd(), plane_id_, DRM_MODE_OBJECT_PLANE));
   if (!plane_props) {
     PLOG(ERROR) << "Unable to get plane properties.";
     return false;
   }
 
   uint32_t count_props = plane_props->count_props;
   for (uint32_t i = 0; i < count_props; i++) {
     ScopedDrmPropertyPtr property(
         drmModeGetProperty(drm->get_fd(), plane_props->props[i]));
     if (property && !strcmp(property->name, kTypePropName)) {
       type_ = GetPlaneType(plane_props->prop_values[i]);
     }
   }
 
   return InitializeProperties(drm, plane_props);
 }
 
-bool HardwareDisplayPlane::IsSupportedFormat(uint32_t format) const {
-  return true;
+bool HardwareDisplayPlane::IsSupportedFormat(uint32_t format) {
+  if (!format)
+    return false;
+
+  if (last_used_format_ == format)
+    return true;
+
+  for (auto& element : supported_formats_) {
+    if (element == format) {
+      last_used_format_ = format;
+      return true;
+    }
+  }
+
+  last_used_format_ = 0;
+  return false;
 }
 
 bool HardwareDisplayPlane::InitializeProperties(
     DrmDevice* drm,
     const ScopedDrmObjectPropertyPtr& plane_props) {
   return true;
 }
 
 }  // namespace ui