Move Format checks to HardwareDisplayPlane

ui/ozone/platform/drm/gpu/hardware_display_plane.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/gpu/hardware_display_plane.h"
 
 #include <drm.h>
+#include <gbm.h>

[dnicoara, 2015/08/25 19:27:16]

The bots are not going to like this include since gbm isn't available on the
non-CrOS bots. This was fine on the atomic path since it is never compiled on
the bots.

Likely need to do the GBM_BO_FORMAT_* to DRM_FORMAT_* conversion in
gbm_buffer.cc for simplicity, then just assume DRM_FORMAT_* here (would you mind
updating the interface comment and mention what the format is supposed to be?)

FYI: I'm debating whether an explicit switch-case statement should be used for
GBM_BO_FORMAT_* to DRM_FORMAT_* for clarity. On the other hand it seems like it
shouldn't matter since the gbm version is identical. You may have a better
insight on this.

[kalyank, 2015/08/26 08:42:42]

Done.

[kalyank, 2015/08/26 08:42:42]

GBM_BO_FORMAT_* are enum values. We have GBM_FORMAT_* which should be identical
to DRM_FORMAT_*. However, we need to pass GBM_FORMAT_* as format type during
buffer creation. This will make sure that gbm_bo_get_format, returns the right
value. I have made necessary changes for this in GbmBuffer

+#include <drm/drm_fourcc.h>
 #include <xf86drm.h>
 
 #include "base/logging.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/ozone/platform/drm/gpu/drm_device.h"
 
 namespace ui {
 
 HardwareDisplayPlane::HardwareDisplayPlane(uint32_t plane_id,
                                            uint32_t possible_crtcs)
     : plane_id_(plane_id), possible_crtcs_(possible_crtcs) {
 }
 
 HardwareDisplayPlane::~HardwareDisplayPlane() {
 }
 
 bool HardwareDisplayPlane::CanUseForCrtc(uint32_t crtc_index) {
   return possible_crtcs_ & (1 << crtc_index);
 }
 
 bool HardwareDisplayPlane::Initialize(DrmDevice* drm,
                                       const std::vector<uint32_t>& formats) {
   return true;
 }
 
 bool HardwareDisplayPlane::IsSupportedFormat(uint32_t format) const {
-  return true;
+  uint32_t format_type = 0;

[kalyank, 2015/08/24 17:22:00]

Depends on https://codereview.chromium.org/1294113005/ and needs to rebased
after that.

+  switch (format) {
+    case GBM_BO_FORMAT_ARGB8888: {
+      // We create a FB of 24 bit color depth.
+      format_type = DRM_FORMAT_XRGB8888;
+      break;
+    }
+    case GBM_BO_FORMAT_XRGB8888: {
+      format_type = DRM_FORMAT_XRGB8888;
+      break;
+    }
+    default:
+      NOTREACHED();
+      return false;

[dnicoara, 2015/08/25 19:27:16]

drm_buffer.cc needs to also be updated to return the correct format.
Historically we didn't care about the software path since it has a limited use
case and just 1 format.

[kalyank, 2015/08/26 08:42:42]

Done.

+  }
+
+  for (auto& element : supported_formats_) {
+    if (element == format_type)
+      return true;
+  }
+
+  return false;
 }
 
 }  // namespace ui