Issue 1314543011: Add fallback fonts for math and symbol blocks on Windows

Issue 1314543011: Add fallback fonts for math and symbol blocks on Windows (Closed)

Created:
5 years, 3 months ago by eae

Modified:
5 years, 3 months ago

Reviewers:
ebraminio, szager, szager1

CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add fallback fonts for math and symbol blocks on Windows Add fallback fonts for more math and symbol unicode blocks on Windows to allow better font fallback and handling of symbols that generally aren't available in the commonly used fonts. R=szager@chromium.org BUG=237023, 237050, 526354 TEST=fast/text/unicode-fallback-font.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201930

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -13 lines)			Patch
	M	LayoutTests/TestExpectations	View	1 2 3	6 chunks	+39 lines, -11 lines	0 comments	Download
	M	Source/platform/fonts/win/FontFallbackWin.cpp	View	1 2	2 chunks	+24 lines, -2 lines	0 comments	Download

Messages

Total messages: 18 (7 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ebraminio

So sorry for bugging you about these, I thought it may be a good time ...

5 years, 3 months ago (2015-09-04 19:56:45 UTC) #2

eae

On 2015/09/04 19:56:45, ebraminio wrote: > So sorry for bugging you about these, I thought ...

5 years, 3 months ago (2015-09-04 20:02:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314543011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314543011/20001

5 years, 3 months ago (2015-09-04 20:28:47 UTC) #9

commit-bot: I haz the power

Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/103567)

5 years, 3 months ago (2015-09-04 21:24:22 UTC) #11

ebraminio

Now that this is not landed yet I just find the chance to note just ...

5 years, 3 months ago (2015-09-04 21:28:24 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314543011/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314543011/60001

5 years, 3 months ago (2015-09-08 20:20:28 UTC) #15

commit-bot: I haz the power

Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201930

5 years, 3 months ago (2015-09-08 21:22:13 UTC) #16

Jeffrey Yasskin

A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1303203004/ by jyasskin@chromium.org. ...

5 years, 3 months ago (2015-09-09 11:39:33 UTC) #17

Message was sent while issue was closed.

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1303203004/ by jyasskin@chromium.org.

The reason for reverting is: This appears to have broken DrMemory. I believe
this isn't your fault; you just exposed the bug that
https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKi...
fails to set *scriptChecked. But I still want to get DrMemory green again.

http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20...

### BEGIN MEMORY TOOL REPORT (error hash=#D08ACED1904C5DA6#)
UNINITIALIZED READ: reading 0x1022d6a0-0x1022d6a4 4 byte(s)
# 0 blink_platform.dll!blink::FontCache::fallbackFontForCharacter      
[third_party\webkit\source\platform\fonts\win\fontcacheskiawin.cpp:188]
# 1 blink_platform.dll!blink::Font::glyphDataForCharacter              
[third_party\webkit\source\platform\fonts\font.cpp:521]
# 2 blink_platform.dll!blink::SimpleShaper::glyphDataForCharacter      
[third_party\webkit\source\platform\fonts\shaping\simpleshaper.cpp:67]
# 3 blink_platform.dll!blink::SimpleShaper::advanceInternal<>          
[third_party\webkit\source\platform\fonts\shaping\simpleshaper.cpp:141]
# 4 blink_platform.dll!blink::SimpleShaper::advance                    
[third_party\webkit\source\platform\fonts\shaping\simpleshaper.cpp:214]
# 5 blink_platform.dll!blink::Font::floatWidthForSimpleText            
[third_party\webkit\source\platform\fonts\font.cpp:750]
# 6 blink_platform.dll!blink::Font::width                              
[third_party\webkit\source\platform\fonts\font.cpp:234]
# 7 webcore_shared.dll!blink::BreakingContext::handleText              
[third_party\webkit\source\core\layout\line\breakingcontextinlineheaders.h:652]
# 8 webcore_shared.dll!blink::LineBreaker::nextLineBreak               
[third_party\webkit\source\core\layout\line\linebreaker.cpp:88]
# 9 webcore_shared.dll!blink::LayoutBlockFlow::layoutRunsAndFloatsInRange
[third_party\webkit\source\core\layout\layoutblockflowline.cpp:807]
#10 webcore_shared.dll!blink::LayoutBlockFlow::layoutRunsAndFloats     
[third_party\webkit\source\core\layout\layoutblockflowline.cpp:756]
#11 webcore_shared.dll!blink::LayoutBlockFlow::layoutInlineChildren    
[third_party\webkit\source\core\layout\layoutblockflowline.cpp:1580]
#12 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockFlow         
[third_party\webkit\source\core\layout\layoutblockflow.cpp:376]
#13 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlock             
[third_party\webkit\source\core\layout\layoutblockflow.cpp:298]
#14 webcore_shared.dll!blink::LayoutBlock::layout                      
[third_party\webkit\source\core\layout\layoutblock.cpp:907]
#15 webcore_shared.dll!blink::LayoutBlockFlow::positionAndLayoutOnceIfNeeded
[third_party\webkit\source\core\layout\layoutblockflow.cpp:562]
#16 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChild        
[third_party\webkit\source\core\layout\layoutblockflow.cpp:587]
#17 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChildren     
[third_party\webkit\source\core\layout\layoutblockflow.cpp:1042]
#18 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockFlow         
[third_party\webkit\source\core\layout\layoutblockflow.cpp:378]
#19 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlock             
[third_party\webkit\source\core\layout\layoutblockflow.cpp:298]
#20 webcore_shared.dll!blink::LayoutBlock::layout                      
[third_party\webkit\source\core\layout\layoutblock.cpp:907]
#21 webcore_shared.dll!blink::LayoutBlockFlow::positionAndLayoutOnceIfNeeded
[third_party\webkit\source\core\layout\layoutblockflow.cpp:562]
#22 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChild        
[third_party\webkit\source\core\layout\layoutblockflow.cpp:587]
#23 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockChildren     
[third_party\webkit\source\core\layout\layoutblockflow.cpp:1042]
#24 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlockFlow         
[third_party\webkit\source\core\layout\layoutblockflow.cpp:378]
#25 webcore_shared.dll!blink::LayoutBlockFlow::layoutBlock             
[third_party\webkit\source\core\layout\layoutblockflow.cpp:298]
#26 webcore_shared.dll!blink::LayoutBlock::layout                      
[third_party\webkit\source\core\layout\layoutblock.cpp:907]
#27 webcore_shared.dll!blink::LayoutView::layout                       
[third_party\webkit\source\core\layout\layoutview.cpp:245]
#28 webcore_shared.dll!blink::FrameView::performLayout                 
[third_party\webkit\source\core\frame\frameview.cpp:865]
#29 webcore_shared.dll!blink::FrameView::layout                        
[third_party\webkit\source\core\frame\frameview.cpp:1027]
#30 webcore_shared.dll!blink::Document::implicitClose                  
[third_party\webkit\source\core\dom\document.cpp:2599]
#31 webcore_shared.dll!blink::HTMLDocumentParser::end                  
[third_party\webkit\source\core\html\parser\htmldocumentparser.cpp:867]
#32 webcore_shared.dll!blink::HTMLDocumentParser::pumpPendingSpeculations
[third_party\webkit\source\core\html\parser\htmldocumentparser.cpp:570]
#33 webcore_shared.dll!blink::HTMLDocumentParser::resumeParsingAfterYield
[third_party\webkit\source\core\html\parser\htmldocumentparser.cpp:314]
#34 scheduler.dll!scheduler::TaskQueueManager::ProcessTaskFromWorkQueue
[components\scheduler\child\task_queue_manager.cc:346]
#35 scheduler.dll!scheduler::TaskQueueManager::DoWork                  
[components\scheduler\child\task_queue_manager.cc:284]
#36 scheduler.dll!base::internal::Invoker<>::Run                       
[base\bind_internal.h:346]
#37 base.dll!base::debug::TaskAnnotator::RunTask                       
[base\debug\task_annotator.cc:51]
#38 base.dll!base::MessageLoop::RunTask                                
[base\message_loop\message_loop.cc:481]
#39 base.dll!base::MessageLoop::DeferOrRunPendingTask                  
[base\message_loop\message_loop.cc:490]
Note: @0:01:06.308 in thread 3248
Note: instruction: cmp    0xfffffff4(%ebp) $0x00000011
The report came from the
`DomSerializerTests.SerializeHTMLDOMWithNonStandardEntities` test.
.

Jeffrey Yasskin

5 years, 3 months ago (2015-09-09 16:51:53 UTC) #18

Message was sent while issue was closed.

I'm rolling forward in https://codereview.chromium.org/1327143002/ instead,
because the attempted rollback collided with autorebaseliner changes in
TestExpectations.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages