[es6] Fix default parameters in arrow functions

[es6] Fix default parameters in arrow functions

R=adamk@chromium.org, wingo@igalia.com
BUG=v8:811
LOG=N

Committed: https://crrev.com/ff932fe8f4f82a6832c4f649ad00b3ae59f53822
Cr-Commit-Position: refs/heads/master@{#30338}

[wingo, 2015-08-24 16:01:48]

lgtm with test nits

https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:3750: // "({a} = {}) => {}",
Perhaps add a pattern for ({a=42})=>{} too?  Unless I am misreading the grammar
of course.   Same thing for array patterns with initializers.  I don't remember
what the state of the implementation is though.

AFAIU default parameters should work now so we probably also need functional
tests, i.e. tests that also invoke the arrow function.

[rossberg, 2015-08-24 16:08:43]

On 2015/08/24 16:01:48, wingo wrote:
> lgtm with test nits
> 
> https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc
> File test/cctest/test-parsing.cc (right):
> 
>
https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc...
> test/cctest/test-parsing.cc:3750: // "({a} = {}) => {}",
> Perhaps add a pattern for ({a=42})=>{} too?  Unless I am misreading the
grammar
> of course.   Same thing for array patterns with initializers.  I don't
remember
> what the state of the implementation is though.

Will do.

> AFAIU default parameters should work now so we probably also need functional
> tests, i.e. tests that also invoke the arrow function.

Those already exist, see harmony/default-parameters.js -- which is why I'm still
surprised that the bogus code was never triggered before.

[rossberg, 2015-08-24 17:01:41]

https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:3750: // "({a} = {}) => {}",
On 2015/08/24 16:01:47, wingo wrote:
> Perhaps add a pattern for ({a=42})=>{} too?  Unless I am misreading the
grammar
> of course.   Same thing for array patterns with initializers.  I don't
remember
> what the state of the implementation is though.

Done.

[adamk, 2015-08-24 17:31:44]

lgtm too

[rossberg, 2015-08-24 17:36:06]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2015-08-24 17:36:06]

The patchset sent to the CQ was uploaded after l-g-t-m from wingo@igalia.com
Link to the patchset: https://codereview.chromium.org/1314543005/#ps40001
(title: "These workj")

[commit-bot: I haz the power, 2015-08-24 17:36:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314543005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314543005/40001

[commit-bot: I haz the power, 2015-08-24 18:01:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-24 18:01:12]

Patchset 3 (id:??) landed as
https://crrev.com/ff932fe8f4f82a6832c4f649ad00b3ae59f53822
Cr-Commit-Position: refs/heads/master@{#30338}