Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: src/messages.cc

Issue 1314543004: Message formatting: handle unexpected case of failing property lookup. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-523308.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.cc
diff --git a/src/messages.cc b/src/messages.cc
index fd10d45d4a02c59f9c43dc5b1a9c7f4c446bf289..a8afa3f5a75067c76c173d301c3d41b0a789a4bc 100644
--- a/src/messages.cc
+++ b/src/messages.cc
@@ -449,6 +449,7 @@ MaybeHandle<String> ErrorToStringHelper::Stringify(Isolate* isolate,
bool ErrorToStringHelper::ShadowsInternalError(
Isolate* isolate, LookupIterator* property_lookup,
LookupIterator* internal_error_lookup) {
+ if (!property_lookup->IsFound()) return false;
Handle<JSObject> holder = property_lookup->GetHolder<JSObject>();
// It's fine if the property is defined on the error itself.
if (holder.is_identical_to(property_lookup->GetReceiver())) return true;
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-523308.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698