Issue 131453017: Revert of Add the perceptual difference metric to the rebaseline server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131453017: Revert of Add the perceptual difference metric to the rebaseline server (Closed)

Created:
6 years, 10 months ago by rmistry

Modified:
6 years, 10 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Add the perceptual difference metric to the rebaseline server (https://codereview.chromium.org/147453003/) Reason for revert: Caused failure in RunGmSelfTests: http://108.170.219.160:10117/builders/Housekeeper-PerCommit/builds/154/steps/RunGmSelfTests/logs/stdio Filed: https://code.google.com/p/skia/issues/detail?id=2160 Original issue's description: > Add the perceptual difference metric to the rebaseline server > > * Finds the location of the skpdiff binary. > * Calculates the perceptual difference percentage using the skpdiff binary. > * Replaces the weightedDiffMeasure in view.html with perceptualDifferent. > > BUG=skia:2019 > NOTRY=true > > Committed: http://code.google.com/p/skia/source/detail?r=13398 TBR=epoger@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2019 Committed: http://code.google.com/p/skia/source/detail?r=13399

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -52 lines)			Patch
M	gm/rebaseline_server/imagediffdb.py	View	3 chunks	+0 lines, -37 lines	0 comments	Download
M	gm/rebaseline_server/imagediffdb_test.py	View	3 chunks	+5 lines, -8 lines	0 comments	Download
M	gm/rebaseline_server/results.py	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	gm/rebaseline_server/static/view.html	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

rmistry

Created Revert of Add the perceptual difference metric to the rebaseline server

6 years, 10 months ago (2014-02-11 13:30:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/131453017/1

6 years, 10 months ago (2014-02-11 13:30:26 UTC) #2

Message was sent while issue was closed.

Change committed as 13399