Issue 131453010: IDL compiler: [RaisesException] on interface type attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131453010: IDL compiler: [RaisesException] on interface type attributes (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)

Modified:
6 years, 9 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: [RaisesException] on interface type attributes 15 => 12 BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166453

Patch Set 1 #

Patch Set 2 : Simpler #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -11 lines)			Patch
M	Source/bindings/scripts/unstable/v8_attributes.py	View	1	2 chunks	+13 lines, -11 lines	0 comments	Download
M	Source/bindings/tests/idls/TestObjectPython.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View		2 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 10 months ago (2014-02-05 05:30:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/131453010/10004

6 years, 10 months ago (2014-02-05 05:31:26 UTC) #4

Nils Barth (inactive)

6 years, 9 months ago (2014-03-20 03:43:16 UTC) #6

Message was sent while issue was closed.

For reference, a much earlier CL that implemented this was:
IDL compiler: [RaisesException] interface type attribute
https://codereview.chromium.org/117063002/

This CL (the one that was committed) is much simpler,
since we'd already added generic support for .release(),
as it's needed more widely.

Expand Messages | Collapse Messages