Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1314503008: Popular sites on the NTP: check that experiment group StartsWith (rather than IS) "Enabled" (Closed)

Created:
5 years, 3 months ago by Marc Treib
Modified:
5 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@thumbnails
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Popular sites on the NTP: check that experiment group StartsWith (rather than IS) "Enabled" This will give us the option of creating additional "enabled" groups in the future BUG=516618 Committed: https://crrev.com/eba6ceed44d6a0c6b327adf05c8aa7b3dfdd577a Cr-Commit-Position: refs/heads/master@{#347920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/android/most_visited_sites.cc View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Marc Treib
5 years, 3 months ago (2015-09-09 09:11:14 UTC) #2
Bernhard Bauer
lgtm
5 years, 3 months ago (2015-09-09 13:02:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314503008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314503008/1
5 years, 3 months ago (2015-09-09 13:05:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 13:26:08 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 13:26:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eba6ceed44d6a0c6b327adf05c8aa7b3dfdd577a
Cr-Commit-Position: refs/heads/master@{#347920}

Powered by Google App Engine
This is Rietveld 408576698