Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: remoting/host/heartbeat_sender_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/desktop_session_proxy.cc ('k') | remoting/host/host_change_notification_listener_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/heartbeat_sender_unittest.cc
diff --git a/remoting/host/heartbeat_sender_unittest.cc b/remoting/host/heartbeat_sender_unittest.cc
index 99880b405b0c0b45d3b384f1b627ee43aa5c5df6..ea5eeb8bf76d24d3ea60bc03982f0101740dfdca 100644
--- a/remoting/host/heartbeat_sender_unittest.cc
+++ b/remoting/host/heartbeat_sender_unittest.cc
@@ -176,9 +176,9 @@ TEST_F(HeartbeatSenderTest, DoSendStanzaWithExpectedSequenceId) {
.WillOnce(DoAll(SaveArg<0>(&sent_iq2), Return(true)));
scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
- response->AddAttr(QName("", "type"), "result");
- XmlElement* result = new XmlElement(
- QName(kChromotingXmlNamespace, "heartbeat-result"));
+ response->AddAttr(QName(std::string(), "type"), "result");
+ XmlElement* result =
+ new XmlElement(QName(kChromotingXmlNamespace, "heartbeat-result"));
response->AddElement(result);
XmlElement* expected_sequence_id = new XmlElement(
QName(kChromotingXmlNamespace, "expected-sequence-id"));
@@ -200,7 +200,7 @@ TEST_F(HeartbeatSenderTest, DoSendStanzaWithExpectedSequenceId) {
// Verify that ProcessResponse parses set-interval result.
TEST_F(HeartbeatSenderTest, ProcessResponseSetInterval) {
scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
- response->AddAttr(QName("", "type"), "result");
+ response->AddAttr(QName(std::string(), "type"), "result");
XmlElement* result = new XmlElement(
QName(kChromotingXmlNamespace, "heartbeat-result"));
@@ -221,9 +221,9 @@ TEST_F(HeartbeatSenderTest, ProcessResponseSetInterval) {
// Validate a heartbeat stanza.
void HeartbeatSenderTest::ValidateHeartbeatStanza(
XmlElement* stanza, const char* expectedSequenceId) {
- EXPECT_EQ(stanza->Attr(buzz::QName("", "to")),
+ EXPECT_EQ(stanza->Attr(buzz::QName(std::string(), "to")),
std::string(kTestBotJid));
- EXPECT_EQ(stanza->Attr(buzz::QName("", "type")), "set");
+ EXPECT_EQ(stanza->Attr(buzz::QName(std::string(), "type")), "set");
XmlElement* heartbeat_stanza =
stanza->FirstNamed(QName(kChromotingXmlNamespace, "heartbeat"));
ASSERT_TRUE(heartbeat_stanza != NULL);
« no previous file with comments | « remoting/host/desktop_session_proxy.cc ('k') | remoting/host/host_change_notification_listener_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698