extensions/common/extension_resource_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_resource_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/extension_resource_unittest.cc

diff --git a/extensions/common/extension_resource_unittest.cc b/extensions/common/extension_resource_unittest.cc

index 132e7182f67cde3f68bf6d39237fa43e9a14de16..3791b14885831fae8e88a0a6991e97bbe7c0a708 100644

--- a/extensions/common/extension_resource_unittest.cc

+++ b/extensions/common/extension_resource_unittest.cc

@@ -131,7 +131,8 @@ TEST(ExtensionResourceTest, CreateWithAllResourcesOnDisk) {

ASSERT_TRUE(file_util::CreateDirectory(l10n_path));

std::vector<std::string> locales;

- l10n_util::GetParentLocales(l10n_util::GetApplicationLocale(""), &locales);

+ l10n_util::GetParentLocales(l10n_util::GetApplicationLocale(std::string()),

+ &locales);

ASSERT_FALSE(locales.empty());

for (size_t i = 0; i < locales.size(); i++) {

base::FilePath make_path;