chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc

diff --git a/chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc b/chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc

index fd5ca6fd7cd98cde12e09e7854a8bfb08e366bf1..47d6bdb45a9e219e7da8c68cc4c2636fe040af7f 100644

--- a/chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc

+++ b/chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc

@@ -301,7 +301,7 @@ IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, EnableSpellingService) {

new SpellingMenuObserver(menu.get()));

menu->SetObserver(observer.get());

menu->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);

- menu->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "");

+ menu->GetPrefs()->SetString(prefs::kSpellCheckDictionary, std::string());

content::ContextMenuParams params;

params.is_editable = true;