chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('k') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index f5fd98b1502670fb65485c38f30522dfdd2aab5a..ed533604b472541b9d48a8fd798c609c334251e6 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -252,9 +252,8 @@ TEST_F(ClientSideDetectionServiceTest, FetchModelTest) {

Mock::VerifyAndClearExpectations(&service);

// Empty model file.

- SetModelFetchResponse("", true /* success */);

- EXPECT_CALL(service, EndFetchModel(

- ClientSideDetectionService::MODEL_EMPTY))

+ SetModelFetchResponse(std::string(), true /* success */);

+ EXPECT_CALL(service, EndFetchModel(ClientSideDetectionService::MODEL_EMPTY))

.WillOnce(QuitCurrentMessageLoop());

service.StartFetchModel();

msg_loop_.Run(); // EndFetchModel will quit the message loop.

@@ -576,7 +575,7 @@ TEST_F(ClientSideDetectionServiceTest, IsBadIpAddress) {

ClientSideDetectionService::SetBadSubnets(

model, &(csd_service_->bad_subnets_));

EXPECT_FALSE(csd_service_->IsBadIpAddress("blabla"));

- EXPECT_FALSE(csd_service_->IsBadIpAddress(""));

+ EXPECT_FALSE(csd_service_->IsBadIpAddress(std::string()));

EXPECT_TRUE(csd_service_->IsBadIpAddress(

"2620:0:1000:3103:21a:a0ff:fe10:786e"));