sync/internal_api/public/base/ordinal_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/ordinal_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base/ordinal_unittest.cc

diff --git a/sync/internal_api/public/base/ordinal_unittest.cc b/sync/internal_api/public/base/ordinal_unittest.cc

index 20a6d194edf66651fcb94afc7c2268e268113f68..8c77d6d6582c5bb9fd487376e99541d445644600 100644

--- a/sync/internal_api/public/base/ordinal_unittest.cc

+++ b/sync/internal_api/public/base/ordinal_unittest.cc

@@ -87,7 +87,7 @@ COMPILE_ASSERT(LargeOrdinal::kRadix == 256,

// IsValid() should return false for all of them.

TEST(Ordinal, Invalid) {

// Length criterion.

- EXPECT_FALSE(TestOrdinal("").IsValid());

+ EXPECT_FALSE(TestOrdinal(std::string()).IsValid());

EXPECT_FALSE(LongOrdinal("0001").IsValid());

const char kBeforeZero[] = { '0' - 1, '\0' };