Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: remoting/host/setup/daemon_controller_linux.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/service_client.cc ('k') | remoting/host/setup/oauth_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/setup/daemon_controller_linux.cc
diff --git a/remoting/host/setup/daemon_controller_linux.cc b/remoting/host/setup/daemon_controller_linux.cc
index f5076d4acbe704a40f8650eee2533f92006702e7..216572fc2e24816b588974290b7cdf9ec677c0dc 100644
--- a/remoting/host/setup/daemon_controller_linux.cc
+++ b/remoting/host/setup/daemon_controller_linux.cc
@@ -318,7 +318,7 @@ void DaemonControllerLinux::DoGetVersion(
const GetVersionCallback& done_callback) {
base::FilePath script_path;
if (!GetScriptPath(&script_path)) {
- done_callback.Run("");
+ done_callback.Run(std::string());
return;
}
CommandLine command_line(script_path);
@@ -331,14 +331,14 @@ void DaemonControllerLinux::DoGetVersion(
if (!result || exit_code != 0) {
LOG(ERROR) << "Failed to run \"" << command_line.GetCommandLineString()
<< "\". Exit code: " << exit_code;
- done_callback.Run("");
+ done_callback.Run(std::string());
return;
}
TrimWhitespaceASCII(version, TRIM_ALL, &version);
if (!ContainsOnlyChars(version, "0123456789.")) {
LOG(ERROR) << "Received invalid host version number: " << version;
- done_callback.Run("");
+ done_callback.Run(std::string());
return;
}
« no previous file with comments | « remoting/host/service_client.cc ('k') | remoting/host/setup/oauth_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698