extensions/common/matcher/url_matcher.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/matcher/url_matcher.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/matcher/url_matcher.cc

diff --git a/extensions/common/matcher/url_matcher.cc b/extensions/common/matcher/url_matcher.cc

index d7779a259206ccfb551d0d23bad92402e121a157..b5992930c58d9ae6f54b1a761d6e0144a2e4ca4c 100644

--- a/extensions/common/matcher/url_matcher.cc

+++ b/extensions/common/matcher/url_matcher.cc

@@ -256,8 +256,8 @@ URLMatcherConditionFactory::~URLMatcherConditionFactory() {

std::string URLMatcherConditionFactory::CanonicalizeURLForComponentSearches(

const GURL& url) const {

return kBeginningOfURL + CanonicalizeHostname(url.host()) + kEndOfDomain +

- url.path() + kEndOfPath + (url.has_query() ? "?" + url.query() : "") +

- kEndOfURL;

+ url.path() + kEndOfPath +

+ (url.has_query() ? "?" + url.query() : std::string()) + kEndOfURL;

}

URLMatcherCondition URLMatcherConditionFactory::CreateHostPrefixCondition(