content/browser/geolocation/wifi_data_provider_linux.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/wifi_data_provider_linux.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/geolocation/wifi_data_provider_linux.cc

diff --git a/content/browser/geolocation/wifi_data_provider_linux.cc b/content/browser/geolocation/wifi_data_provider_linux.cc

index 709063a582118a6920d3b5f55388ef886a93cad7..c8d68ac8e2e21a2afb0b60e1e7cf5e2e2e79d240 100644

--- a/content/browser/geolocation/wifi_data_provider_linux.cc

+++ b/content/browser/geolocation/wifi_data_provider_linux.cc

@@ -270,7 +270,7 @@ bool NetworkManagerWlanApi::GetAccessPointsForAdapter(

continue;

}

- ReplaceSubstringsAfterOffset(&mac, 0U, ":", "");

+ ReplaceSubstringsAfterOffset(&mac, 0U, ":", std::string());

std::vector<uint8> mac_bytes;

if (!base::HexStringToBytes(mac, &mac_bytes) || mac_bytes.size() != 6) {

LOG(WARNING) << "Can't parse mac address (found " << mac_bytes.size()