content/browser/download/download_stats.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_stats.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_stats.cc

diff --git a/content/browser/download/download_stats.cc b/content/browser/download/download_stats.cc

index cad6cbe4bac245454522b354b6c6a05f10a2bbcb..e13200e57b4a8de0914ae1b16b65121287e79d74 100644

--- a/content/browser/download/download_stats.cc

+++ b/content/browser/download/download_stats.cc

@@ -305,8 +305,8 @@ void RecordDownloadContentDisposition(

const std::string& content_disposition_string) {

if (content_disposition_string.empty())

return;

- net::HttpContentDisposition content_disposition(

- content_disposition_string, "");

+ net::HttpContentDisposition content_disposition(content_disposition_string,

+ std::string());

int result = content_disposition.parse_result_flags();

bool is_valid = !content_disposition.filename().empty();