chrome/browser/nacl_host/pnacl_file_host_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/pnacl_file_host_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/nacl_host/pnacl_file_host_unittest.cc

diff --git a/chrome/browser/nacl_host/pnacl_file_host_unittest.cc b/chrome/browser/nacl_host/pnacl_file_host_unittest.cc

index eb2a74a7b0c685dec5981d630a0617a70a4f0b29..6e30c29bb5eebd19b86b5eac970b8a3886fd37cb 100644

--- a/chrome/browser/nacl_host/pnacl_file_host_unittest.cc

+++ b/chrome/browser/nacl_host/pnacl_file_host_unittest.cc

@@ -57,7 +57,7 @@ TEST(PnaclFileHostTest, TestFilenamesWithPnaclPath) {

&out_path));

// Other bad files.

- EXPECT_FALSE(PnaclCanOpenFile("", &out_path));

+ EXPECT_FALSE(PnaclCanOpenFile(std::string(), &out_path));

EXPECT_FALSE(PnaclCanOpenFile(".", &out_path));

EXPECT_FALSE(PnaclCanOpenFile("..", &out_path));

#if defined(OS_WIN)