chrome/test/chromedriver/chrome/devtools_http_client.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/devtools_http_client.cc

diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.cc b/chrome/test/chromedriver/chrome/devtools_http_client.cc

index c0fc84168857fc8870e7d561a750655a262f143b..3cfcdae1735f9a28f7ec285c54d951236b2c4287 100644

--- a/chrome/test/chromedriver/chrome/devtools_http_client.cc

+++ b/chrome/test/chromedriver/chrome/devtools_http_client.cc

@@ -169,7 +169,8 @@ Status DevToolsHttpClient::CloseFrontends(const std::string& for_client_id) {

scoped_ptr<base::Value> result;

status = web_view->EvaluateScript(

- "", "document.querySelector('*[id^=\"close-button-\"').click();",

+ std::string(),

+ "document.querySelector('*[id^=\"close-button-\"').click();",

&result);

// Ignore disconnected error, because it may be closed already.

if (status.IsError() && status.code() != kDisconnected)