chrome/common/extensions/extension_set.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_set.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_set.cc

diff --git a/chrome/common/extensions/extension_set.cc b/chrome/common/extensions/extension_set.cc

index 84872b8ab381505934cbc827f2e66cc4df2e75a8..8b68fb6aeef376d02e44e52b3fe5b281e61c87f9 100644

--- a/chrome/common/extensions/extension_set.cc

+++ b/chrome/common/extensions/extension_set.cc

@@ -77,11 +77,11 @@ std::string ExtensionSet::GetExtensionOrAppIDByURL(

DCHECK(!info.origin().isNull());

if (info.url().SchemeIs(extensions::kExtensionScheme))

- return info.origin().isUnique() ? "" : info.url().host();

+ return info.origin().isUnique() ? std::string() : info.url().host();

const Extension* extension = GetExtensionOrAppByURL(info);

if (!extension)

- return "";

+ return std::string();

return extension->id();

}