Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc
diff --git a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc
index 84277176a74398350a4f4b3b613b706984f5dc22..ac5040ceba6249291e9ca090fdfcaf882d9b7ac5 100644
--- a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc
+++ b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc
@@ -100,15 +100,13 @@ TEST_F(BrowserActionManifestTest,
TEST_F(BrowserActionManifestTest,
BrowserActionManifestIcons_InvalidDefaultIcon) {
scoped_ptr<DictionaryValue> manifest_value = DictionaryBuilder()
- .Set("name", "Invalid default icon")
- .Set("version", "1.0.0")
+ .Set("name", "Invalid default icon").Set("version", "1.0.0")
.Set("manifest_version", 2)
- .Set("browser_action", DictionaryBuilder()
- .Set("default_icon", DictionaryBuilder()
- .Set("19", "") // Invalid value.
- .Set("24", "icon24.png")
- .Set("38", "icon38.png")))
- .Build();
+ .Set("browser_action",
+ DictionaryBuilder().Set(
+ "default_icon",
+ DictionaryBuilder().Set("19", std::string()) // Invalid value.
+ .Set("24", "icon24.png").Set("38", "icon38.png"))).Build();
string16 error = ErrorUtils::FormatErrorMessageUTF16(
errors::kInvalidIconPath, "19");
« no previous file with comments | « chrome/common/extensions/api/commands/commands_handler.cc ('k') | chrome/common/extensions/api/extension_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698