Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/value_store/leveldb_value_store.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/version_ui.cc ('k') | chrome/browser/web_applications/web_app_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/value_store/leveldb_value_store.cc
diff --git a/chrome/browser/value_store/leveldb_value_store.cc b/chrome/browser/value_store/leveldb_value_store.cc
index 47ad0c0b2723de9aa1f374374fadb5f46d91de11..bad05dd9eb11c268a9882724b85a99fef0132541 100644
--- a/chrome/browser/value_store/leveldb_value_store.cc
+++ b/chrome/browser/value_store/leveldb_value_store.cc
@@ -334,7 +334,7 @@ std::string LeveldbValueStore::EnsureDbIsOpen() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
if (db_.get())
- return "";
+ return std::string();
#if defined(OS_POSIX)
std::string os_path(db_path_.value());
@@ -356,7 +356,7 @@ std::string LeveldbValueStore::EnsureDbIsOpen() {
}
db_.reset(db);
- return "";
+ return std::string();
}
std::string LeveldbValueStore::ReadFromDb(
@@ -371,7 +371,7 @@ std::string LeveldbValueStore::ReadFromDb(
if (s.IsNotFound()) {
// Despite there being no value, it was still a success.
// Check this first because ok() is false on IsNotFound.
- return "";
+ return std::string();
}
if (!s.ok())
@@ -384,7 +384,7 @@ std::string LeveldbValueStore::ReadFromDb(
}
setting->reset(value);
- return "";
+ return std::string();
}
std::string LeveldbValueStore::AddToBatch(
@@ -410,16 +410,16 @@ std::string LeveldbValueStore::AddToBatch(
batch->Put(key, value_as_json);
}
- return "";
+ return std::string();
}
std::string LeveldbValueStore::WriteToDb(leveldb::WriteBatch* batch) {
leveldb::Status status = db_->Write(leveldb::WriteOptions(), batch);
if (status.IsNotFound()) {
NOTREACHED() << "IsNotFound() but writing?!";
- return "";
+ return std::string();
}
- return status.ok() ? "" : status.ToString();
+ return status.ok() ? std::string() : status.ToString();
}
bool LeveldbValueStore::IsEmpty() {
« no previous file with comments | « chrome/browser/ui/webui/version_ui.cc ('k') | chrome/browser/web_applications/web_app_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698