chrome/browser/sync/test/integration/sync_extension_helper.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/sync_extension_helper.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/test/integration/sync_extension_helper.cc

diff --git a/chrome/browser/sync/test/integration/sync_extension_helper.cc b/chrome/browser/sync/test/integration/sync_extension_helper.cc

index 84cf7547460ad9708c432fec365ea3877249bbe4..fc007af909ef6068f94ddc405bcfb939931a0a64 100644

--- a/chrome/browser/sync/test/integration/sync_extension_helper.cc

+++ b/chrome/browser/sync/test/integration/sync_extension_helper.cc

@@ -63,7 +63,7 @@ std::string SyncExtensionHelper::InstallExtension(

scoped_refptr<Extension> extension = GetExtension(profile, name, type);

if (!extension.get()) {

NOTREACHED() << "Could not install extension " << name;

- return "";

+ return std::string();

}

profile->GetExtensionService()->OnExtensionInstalled(

extension, syncer::StringOrdinal(), false /* no requirement errors */,