Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/internal_auth_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/importer/firefox_importer_utils.cc ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/internal_auth_unittest.cc
diff --git a/chrome/browser/internal_auth_unittest.cc b/chrome/browser/internal_auth_unittest.cc
index 42080cd33b5e151881946c38fe44c42e4f814a3a..da8954eb52a2fdcea0aca4550b0d817d1d4ef8aa 100644
--- a/chrome/browser/internal_auth_unittest.cc
+++ b/chrome/browser/internal_auth_unittest.cc
@@ -69,9 +69,10 @@ TEST_F(InternalAuthTest, BadGeneration) {
token, long_string_, map));
// Trying empty domain.
- token = InternalAuthGeneration::GeneratePassport("", map);
+ token = InternalAuthGeneration::GeneratePassport(std::string(), map);
ASSERT_TRUE(token.empty());
- ASSERT_FALSE(InternalAuthVerification::VerifyPassport(token, "", map));
+ ASSERT_FALSE(
+ InternalAuthVerification::VerifyPassport(token, std::string(), map));
std::string dummy("abcdefghij");
for (size_t i = 1000; i--;) {
@@ -87,7 +88,7 @@ TEST_F(InternalAuthTest, BadGeneration) {
ASSERT_FALSE(InternalAuthVerification::VerifyPassport(token, "zapata", map));
map.clear();
- map[""] = "value";
+ map[std::string()] = "value";
// Trying empty key.
token = InternalAuthGeneration::GeneratePassport("zapata", map);
ASSERT_TRUE(token.empty());
« no previous file with comments | « chrome/browser/importer/firefox_importer_utils.cc ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698