Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5111)

Unified Diff: chrome/browser/google/google_util_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/google/google_util.cc ('k') | chrome/browser/google_apis/base_operations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_util_unittest.cc
diff --git a/chrome/browser/google/google_util_unittest.cc b/chrome/browser/google/google_util_unittest.cc
index cf4c6100310831e803e765b2997e5cb10d3b34c6..75b706773b31708c103bafdcb65f1765052b3147 100644
--- a/chrome/browser/google/google_util_unittest.cc
+++ b/chrome/browser/google/google_util_unittest.cc
@@ -53,7 +53,7 @@ TEST(GoogleUtilTest, GoodHomePagesSecure) {
}
TEST(GoogleUtilTest, BadHomePages) {
- EXPECT_FALSE(IsGoogleHomePageUrl(""));
+ EXPECT_FALSE(IsGoogleHomePageUrl(std::string()));
// If specified, only the "www" subdomain is OK.
EXPECT_FALSE(IsGoogleHomePageUrl("http://maps.google.com"));
@@ -237,7 +237,7 @@ TEST(GoogleUtilTest, BadSearches) {
"http://www.google.com/search/nogood?q=something"));
EXPECT_FALSE(IsGoogleSearchUrl(
"http://www.google.com/webhp/nogood#q=something"));
- EXPECT_FALSE(IsGoogleSearchUrl(""));
+ EXPECT_FALSE(IsGoogleSearchUrl(std::string()));
// Case sensitive paths.
EXPECT_FALSE(IsGoogleSearchUrl(
« no previous file with comments | « chrome/browser/google/google_util.cc ('k') | chrome/browser/google_apis/base_operations.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698