chrome/browser/extensions/component_loader_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/component_loader_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/component_loader_unittest.cc

diff --git a/chrome/browser/extensions/component_loader_unittest.cc b/chrome/browser/extensions/component_loader_unittest.cc

index bedcfee16bf83673bdb0d2a4c389f500bdb48423..4b2b52a9f0f107bec44192b92b4497b44fdf230d 100644

--- a/chrome/browser/extensions/component_loader_unittest.cc

+++ b/chrome/browser/extensions/component_loader_unittest.cc

@@ -141,7 +141,7 @@ TEST_F(ComponentLoaderTest, ParseManifest) {

// Test manifests that are valid JSON, but don't have an object literal

// at the root. ParseManifest() should always return NULL.

- manifest.reset(component_loader_.ParseManifest(""));

+ manifest.reset(component_loader_.ParseManifest(std::string()));

EXPECT_FALSE(manifest.get());

manifest.reset(component_loader_.ParseManifest("[{ \"foo\": 3 }]"));