ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

index a7d3f24f17fc2c614cd8715893f62f7cec690064..ff0982ef73f9e3acd24845d9752ec99fab5c2ec0 100644

--- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

+++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

@@ -224,9 +224,7 @@ void PnaclTranslateThread::DoTranslate() {

}

PLUGIN_PRINTF(("PnaclTranslateThread done with chunks\n"));

// Finish llc.

- if(!llc_subprocess_->InvokeSrpcMethod("StreamEnd",

- "",

- &params)) {

+ if (!llc_subprocess_->InvokeSrpcMethod("StreamEnd", std::string(), &params)) {

PLUGIN_PRINTF(("PnaclTranslateThread StreamEnd failed\n"));

if (llc_subprocess_->srpc_client()->GetLastError() ==

NACL_SRPC_RESULT_APP_ERROR) {