Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2917)

Unified Diff: net/http/http_auth_filter_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_cache_unittest.cc ('k') | net/http/http_auth_gssapi_posix_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_filter_unittest.cc
diff --git a/net/http/http_auth_filter_unittest.cc b/net/http/http_auth_filter_unittest.cc
index 0aab9d471be72002a6aa8a4ec82d9a4440b4fac7..e6891dd09869349aa869c9fb95a4660130d2434b 100644
--- a/net/http/http_auth_filter_unittest.cc
+++ b/net/http/http_auth_filter_unittest.cc
@@ -35,22 +35,17 @@ struct UrlData {
};
static const UrlData urls[] = {
- { GURL(""),
- HttpAuth::AUTH_NONE, false, 0 },
- { GURL("http://foo.cn"),
- HttpAuth::AUTH_PROXY, true, ALL_SERVERS_MATCH },
- { GURL("http://foo.cn"),
- HttpAuth::AUTH_SERVER, false, 0 },
- { GURL("http://slashdot.org"),
- HttpAuth::AUTH_NONE, false, 0 },
- { GURL("http://www.google.com"),
- HttpAuth::AUTH_SERVER, true, 1 << 0 },
- { GURL("http://www.google.com"),
- HttpAuth::AUTH_PROXY, true, ALL_SERVERS_MATCH },
+ { GURL(std::string()), HttpAuth::AUTH_NONE, false, 0 },
+ { GURL("http://foo.cn"), HttpAuth::AUTH_PROXY, true, ALL_SERVERS_MATCH },
+ { GURL("http://foo.cn"), HttpAuth::AUTH_SERVER, false, 0 },
+ { GURL("http://slashdot.org"), HttpAuth::AUTH_NONE, false, 0 },
+ { GURL("http://www.google.com"), HttpAuth::AUTH_SERVER, true, 1 << 0 },
+ { GURL("http://www.google.com"), HttpAuth::AUTH_PROXY, true,
+ ALL_SERVERS_MATCH },
{ GURL("https://login.facebook.com/login.php?login_attempt=1"),
HttpAuth::AUTH_NONE, false, 0 },
- { GURL("http://codereview.chromium.org/634002/show"),
- HttpAuth::AUTH_SERVER, true, 1 << 3 },
+ { GURL("http://codereview.chromium.org/634002/show"), HttpAuth::AUTH_SERVER,
+ true, 1 << 3 },
{ GURL("http://code.google.com/p/chromium/issues/detail?id=34505"),
HttpAuth::AUTH_SERVER, true, 1 << 0 },
{ GURL("http://code.google.com/p/chromium/issues/list?can=2&q=label:"
@@ -77,7 +72,7 @@ static const UrlData urls[] = {
TEST(HttpAuthFilterTest, EmptyFilter) {
// Create an empty filter
- HttpAuthFilterWhitelist filter("");
+ HttpAuthFilterWhitelist filter((std::string()));
for (size_t i = 0; i < arraysize(urls); i++) {
EXPECT_EQ(urls[i].target == HttpAuth::AUTH_PROXY,
filter.IsValid(urls[i].url, urls[i].target))
« no previous file with comments | « net/http/http_auth_cache_unittest.cc ('k') | net/http/http_auth_gssapi_posix_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698