dbus/string_util_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/string_util_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dbus/string_util_unittest.cc

diff --git a/dbus/string_util_unittest.cc b/dbus/string_util_unittest.cc

index 76bdfcbd2bdc56ad22d5550ce43e0cec7cc98c6c..99eb691049105df348cbe0758c38cf02bdc38866 100644

--- a/dbus/string_util_unittest.cc

+++ b/dbus/string_util_unittest.cc

@@ -10,7 +10,7 @@ TEST(StringUtilTest, IsValidObjectPath) {

EXPECT_TRUE(dbus::IsValidObjectPath("/foo/bar"));

EXPECT_TRUE(dbus::IsValidObjectPath("/hoge_fuga/piyo123"));

// Empty string.

- EXPECT_FALSE(dbus::IsValidObjectPath(""));

+ EXPECT_FALSE(dbus::IsValidObjectPath(std::string()));

// Emptyr elemnt.

EXPECT_FALSE(dbus::IsValidObjectPath("//"));

EXPECT_FALSE(dbus::IsValidObjectPath("/foo//bar"));

« no previous file with comments | « dbus/message_unittest.cc ('k') | dbus/values_util.cc » ('j') | no next file with comments »