content/public/test/test_launcher.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/test_launcher.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/test/test_launcher.cc

diff --git a/content/public/test/test_launcher.cc b/content/public/test/test_launcher.cc

index 40545d54209ac6c33fdd7e9d8982adef3dc87d80..f4635ec5e0b04c1bd8eb3bbe85bb8ec43bb8aaa1 100644

--- a/content/public/test/test_launcher.cc

+++ b/content/public/test/test_launcher.cc

@@ -454,7 +454,7 @@ bool RunTests(TestLauncherDelegate* launcher_delegate,

// Split --gtest_filter at '-', if there is one, to separate into

// positive filter and negative filter portions.

std::string positive_filter = filter;

- std::string negative_filter = "";

+ std::string negative_filter;

size_t dash_pos = filter.find('-');

if (dash_pos != std::string::npos) {

positive_filter = filter.substr(0, dash_pos); // Everything up to the dash.

« no previous file with comments | « content/gpu/gpu_info_collector.cc ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »