Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3558)

Unified Diff: chrome/common/extensions/features/simple_feature.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/simple_feature.cc
diff --git a/chrome/common/extensions/features/simple_feature.cc b/chrome/common/extensions/features/simple_feature.cc
index 13c8573edcdf94ee6c4aaa81db74d4b1cd18306d..4b08c6020d2f60596d3fca102b0b51bef2aff86e 100644
--- a/chrome/common/extensions/features/simple_feature.cc
+++ b/chrome/common/extensions/features/simple_feature.cc
@@ -168,7 +168,7 @@ std::string GetDisplayTypeName(Manifest::Type type) {
}
NOTREACHED();
- return "";
+ return std::string();
}
} // namespace
@@ -229,7 +229,7 @@ std::string SimpleFeature::Parse(const DictionaryValue* value) {
return name() + ": Allowing web_page contexts requires supplying a value " +
"for matches.";
}
- return "";
+ return std::string();
}
Feature::Availability SimpleFeature::IsAvailableToManifest(
@@ -313,7 +313,7 @@ std::string SimpleFeature::GetAvailabilityMessage(
AvailabilityResult result, Manifest::Type type, const GURL& url) const {
switch (result) {
case IS_AVAILABLE:
- return "";
+ return std::string();
case NOT_FOUND_IN_WHITELIST:
return base::StringPrintf(
"'%s' is not allowed for specified extension ID.",
@@ -381,7 +381,7 @@ std::string SimpleFeature::GetAvailabilityMessage(
}
NOTREACHED();
- return "";
+ return std::string();
}
Feature::Availability SimpleFeature::CreateAvailability(
« no previous file with comments | « chrome/common/extensions/features/permission_feature.cc ('k') | chrome/common/extensions/features/simple_feature_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698