chrome/browser/ui/webui/options/browser_options_handler.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/browser_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc

index 48f4f60e8c8644f302cf8aed667a978c77695a69..54c5c31c6ae23053b8fb39c718465f94f61c8353 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.cc

+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc

@@ -1194,8 +1194,11 @@ void BrowserOptionsHandler::HandleSelectDownloadLocation(

ui::SelectFileDialog::SELECT_FOLDER,

l10n_util::GetStringUTF16(IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_TITLE),

pref_service->GetFilePath(prefs::kDownloadDefaultDirectory),

- &info, 0, FILE_PATH_LITERAL(""),

- web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(), NULL);

+ &info,

+ 0,

+ base::FilePath::StringType(),

+ web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(),

+ NULL);

}

void BrowserOptionsHandler::FileSelected(const base::FilePath& path, int index,