Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: chrome/browser/google_apis/drive_api_url_generator_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/drive_api_url_generator_unittest.cc
diff --git a/chrome/browser/google_apis/drive_api_url_generator_unittest.cc b/chrome/browser/google_apis/drive_api_url_generator_unittest.cc
index 818fb2dbfa61b6d9c002a52125c614f299c0fc31..bcb6c6d519d13996c2f31dba9dc0a55d64184824 100644
--- a/chrome/browser/google_apis/drive_api_url_generator_unittest.cc
+++ b/chrome/browser/google_apis/drive_api_url_generator_unittest.cc
@@ -69,7 +69,7 @@ TEST_F(DriveApiUrlGeneratorTest, GetFilelistUrl) {
// Use default URL, if |override_url| is empty.
// Do not add q parameter if |search_string| is empty.
EXPECT_EQ("https://www.googleapis.com/drive/v2/files",
- url_generator_.GetFilelistUrl(GURL(), "").spec());
+ url_generator_.GetFilelistUrl(GURL(), std::string()).spec());
// Set q parameter if non-empty |search_string| is given.
EXPECT_EQ("https://www.googleapis.com/drive/v2/files?q=query",
@@ -77,9 +77,10 @@ TEST_F(DriveApiUrlGeneratorTest, GetFilelistUrl) {
// Use the |override_url| for the base URL if given.
// The behavior for the |search_string| should be as same as above cases.
- EXPECT_EQ("https://localhost/drive/v2/files",
- url_generator_.GetFilelistUrl(
- GURL("https://localhost/drive/v2/files"), "").spec());
+ EXPECT_EQ(
+ "https://localhost/drive/v2/files",
+ url_generator_.GetFilelistUrl(GURL("https://localhost/drive/v2/files"),
+ std::string()).spec());
EXPECT_EQ("https://localhost/drive/v2/files?q=query",
url_generator_.GetFilelistUrl(
GURL("https://localhost/drive/v2/files"), "query").spec());
« no previous file with comments | « chrome/browser/google_apis/drive_api_operations_unittest.cc ('k') | chrome/browser/google_apis/drive_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698