Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5335)

Unified Diff: chrome/browser/extensions/updater/extension_downloader.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/tab_helper.cc ('k') | chrome/browser/extensions/updater/extension_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/updater/extension_downloader.cc
diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc
index 0c04a896ebc999fcf528b097114e298716683f02..f16573294d30713f16f2c974985687c8095d525d 100644
--- a/chrome/browser/extensions/updater/extension_downloader.cc
+++ b/chrome/browser/extensions/updater/extension_downloader.cc
@@ -153,12 +153,7 @@ UpdateDetails::UpdateDetails(const std::string& id, const Version& version)
UpdateDetails::~UpdateDetails() {}
-
-ExtensionDownloader::ExtensionFetch::ExtensionFetch()
- : id(""),
- url(),
- package_hash(""),
- version("") {}
+ExtensionDownloader::ExtensionFetch::ExtensionFetch() : url() {}
ExtensionDownloader::ExtensionFetch::ExtensionFetch(
const std::string& id,
@@ -220,7 +215,11 @@ bool ExtensionDownloader::AddPendingExtension(const std::string& id,
Version version("0.0.0.0");
DCHECK(version.IsValid());
- return AddExtensionData(id, version, Manifest::TYPE_UNKNOWN, update_url, "",
+ return AddExtensionData(id,
+ version,
+ Manifest::TYPE_UNKNOWN,
+ update_url,
+ std::string(),
request_id);
}
@@ -249,7 +248,10 @@ void ExtensionDownloader::StartBlacklistUpdate(
new ManifestFetchData(extension_urls::GetWebstoreUpdateUrl(),
request_id));
DCHECK(blacklist_fetch->base_url().SchemeIsSecure());
- blacklist_fetch->AddExtension(kBlacklistAppID, version, &ping_data, "",
+ blacklist_fetch->AddExtension(kBlacklistAppID,
+ version,
+ &ping_data,
+ std::string(),
kDefaultInstallSource);
StartUpdateCheck(blacklist_fetch.Pass());
}
« no previous file with comments | « chrome/browser/extensions/tab_helper.cc ('k') | chrome/browser/extensions/updater/extension_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698