Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: remoting/protocol/third_party_authenticator_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/libjingle_transport_factory.cc ('k') | remoting/protocol/transport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/third_party_authenticator_unittest.cc
diff --git a/remoting/protocol/third_party_authenticator_unittest.cc b/remoting/protocol/third_party_authenticator_unittest.cc
index b787a62c83668dd0c3a2a50c8b2526bd9202f412..029887794dabd805c9d83322637f985b2ced1db8 100644
--- a/remoting/protocol/third_party_authenticator_unittest.cc
+++ b/remoting/protocol/third_party_authenticator_unittest.cc
@@ -153,7 +153,8 @@ TEST_F(ThirdPartyAuthenticatorTest, ClientNoSecret) {
ASSERT_NO_FATAL_FAILURE(InitAuthenticators());
ASSERT_NO_FATAL_FAILURE(RunHostInitiatedAuthExchange());
ASSERT_EQ(Authenticator::PROCESSING_MESSAGE, client_->state());
- ASSERT_NO_FATAL_FAILURE(token_fetcher_->OnTokenFetched(kToken, ""));
+ ASSERT_NO_FATAL_FAILURE(
+ token_fetcher_->OnTokenFetched(kToken, std::string()));
// The end result is that the client rejected the connection, since it
// couldn't fetch the secret.
@@ -167,7 +168,7 @@ TEST_F(ThirdPartyAuthenticatorTest, InvalidToken) {
ASSERT_NO_FATAL_FAILURE(token_fetcher_->OnTokenFetched(
kToken, kSharedSecret));
ASSERT_EQ(Authenticator::PROCESSING_MESSAGE, host_->state());
- ASSERT_NO_FATAL_FAILURE(token_validator_->OnTokenValidated(""));
+ ASSERT_NO_FATAL_FAILURE(token_validator_->OnTokenValidated(std::string()));
// The end result is that the host rejected the token.
ASSERT_EQ(Authenticator::REJECTED, host_->state());
@@ -177,7 +178,8 @@ TEST_F(ThirdPartyAuthenticatorTest, CannotFetchToken) {
ASSERT_NO_FATAL_FAILURE(InitAuthenticators());
ASSERT_NO_FATAL_FAILURE(RunHostInitiatedAuthExchange());
ASSERT_EQ(Authenticator::PROCESSING_MESSAGE, client_->state());
- ASSERT_NO_FATAL_FAILURE(token_fetcher_->OnTokenFetched("", ""));
+ ASSERT_NO_FATAL_FAILURE(
+ token_fetcher_->OnTokenFetched(std::string(), std::string()));
// The end result is that the client rejected the connection, since it
// couldn't fetch the token.
« no previous file with comments | « remoting/protocol/libjingle_transport_factory.cc ('k') | remoting/protocol/transport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698