chrome/test/webdriver/commands/command.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/commands/command.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/commands/command.cc

diff --git a/chrome/test/webdriver/commands/command.cc b/chrome/test/webdriver/commands/command.cc

index 1471e0a9cba650377563bd829f345103c7beb82c..dfde908e15eb2dca0b1a8744855c7da5930cc450 100644

--- a/chrome/test/webdriver/commands/command.cc

+++ b/chrome/test/webdriver/commands/command.cc

@@ -32,7 +32,7 @@ bool Command::Init(Response* const response) {

void Command::Finish(Response* const response) {}

std::string Command::GetPathVariable(const size_t i) const {

- return i < path_segments_.size() ? path_segments_.at(i) : "";

+ return i < path_segments_.size() ? path_segments_.at(i) : std::string();

}

bool Command::HasParameter(const std::string& key) const {