Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/test/perf/page_cycler_test.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/perf/indexeddb_uitest.cc ('k') | chrome/test/perf/perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/page_cycler_test.cc
diff --git a/chrome/test/perf/page_cycler_test.cc b/chrome/test/perf/page_cycler_test.cc
index 4354faf8d89eeedd5589142a474cedcdd3757728..9d130002dad1b5f01aba6ee05e5a444654f1c250 100644
--- a/chrome/test/perf/page_cycler_test.cc
+++ b/chrome/test/perf/page_cycler_test.cc
@@ -215,10 +215,11 @@ class PageCyclerTest : public UIPerfTest {
// Get the timing cookie value from the DOM automation.
std::wstring wcookie;
- ASSERT_TRUE(tab->ExecuteAndExtractString(L"",
- L"window.domAutomationController.send("
- L"JSON.stringify(__get_timings()));",
- &wcookie));
+ ASSERT_TRUE(tab->ExecuteAndExtractString(
+ std::wstring(),
+ L"window.domAutomationController.send("
+ L"JSON.stringify(__get_timings()));",
+ &wcookie));
cookie = base::SysWideToNativeMB(wcookie);
// JSON.stringify() encapsulates the returned string in quotes, strip them.
@@ -260,8 +261,8 @@ class PageCyclerTest : public UIPerfTest {
printf("Pages: [%s]\n", base::SysWideToNativeMB(pages).c_str());
- perf_test::PrintResultList(graph, "", trace_name, timings, "ms",
- true /* important */);
+ perf_test::PrintResultList(
+ graph, std::string(), trace_name, timings, "ms", true /* important */);
}
void RunTest(const char* graph, const char* name, bool use_http) {
@@ -275,7 +276,7 @@ class PageCyclerTest : public UIPerfTest {
ASSERT_TRUE(tab.get());
std::wstring whistogram;
ASSERT_TRUE(tab->ExecuteAndExtractString(
- L"",
+ std::wstring(),
L"window.domAutomationController.send("
L"window.domAutomationController.getHistogram ? "
L"window.domAutomationController.getHistogram(\"" +
« no previous file with comments | « chrome/test/perf/indexeddb_uitest.cc ('k') | chrome/test/perf/perf_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698