chrome/browser/ui/webui/options/font_settings_handler.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/font_settings_handler.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/font_settings_handler.cc

diff --git a/chrome/browser/ui/webui/options/font_settings_handler.cc b/chrome/browser/ui/webui/options/font_settings_handler.cc

index 61f15248cc4261275de16d9c54c5b7611a11414d..558effc2b0eec36d539be17fd35e8b07a971d0fe 100644

--- a/chrome/browser/ui/webui/options/font_settings_handler.cc

+++ b/chrome/browser/ui/webui/options/font_settings_handler.cc

@@ -188,8 +188,8 @@ void FontSettingsHandler::FontsListHasLoaded(

option->Append(new base::StringValue(has_rtl_chars ? "rtl" : "ltr"));

} else {

// Add empty name/value to indicate a separator item.

- option->Append(new base::StringValue(""));

+ option->Append(new base::StringValue(std::string()));

}

encoding_list.Append(option);

}