Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: net/base/mime_util_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/mime_util.cc ('k') | net/base/net_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mime_util_unittest.cc
diff --git a/net/base/mime_util_unittest.cc b/net/base/mime_util_unittest.cc
index ee6663b05e638ff26e59d320386f0fba78ea2754..565f9deeec7e44c2bf540343a7b2955866830065 100644
--- a/net/base/mime_util_unittest.cc
+++ b/net/base/mime_util_unittest.cc
@@ -93,11 +93,11 @@ TEST(MimeUtilTest, MatchesMimeType) {
"application/html+xml"));
EXPECT_TRUE(MatchesMimeType("application/*+xml", "application/+xml"));
EXPECT_TRUE(MatchesMimeType("aaa*aaa", "aaaaaa"));
- EXPECT_TRUE(MatchesMimeType("*", ""));
+ EXPECT_TRUE(MatchesMimeType("*", std::string()));
EXPECT_FALSE(MatchesMimeType("video/", "video/x-mpeg"));
- EXPECT_FALSE(MatchesMimeType("", "video/x-mpeg"));
- EXPECT_FALSE(MatchesMimeType("", ""));
- EXPECT_FALSE(MatchesMimeType("video/x-mpeg", ""));
+ EXPECT_FALSE(MatchesMimeType(std::string(), "video/x-mpeg"));
+ EXPECT_FALSE(MatchesMimeType(std::string(), std::string()));
+ EXPECT_FALSE(MatchesMimeType("video/x-mpeg", std::string()));
EXPECT_FALSE(MatchesMimeType("application/*+xml", "application/xml"));
EXPECT_FALSE(MatchesMimeType("application/*+xml",
"application/html+xmlz"));
@@ -219,7 +219,7 @@ TEST(MimeUtilTest, TestIsMimeType) {
TEST(MimeUtilTest, TestToIANAMediaType) {
EXPECT_EQ("", GetIANAMediaType("texting/driving"));
EXPECT_EQ("", GetIANAMediaType("ham/sandwich"));
- EXPECT_EQ("", GetIANAMediaType(""));
+ EXPECT_EQ("", GetIANAMediaType(std::string()));
EXPECT_EQ("", GetIANAMediaType("/application/hamsandwich"));
EXPECT_EQ("application", GetIANAMediaType("application/poodle-wrestler"));
« no previous file with comments | « net/base/mime_util.cc ('k') | net/base/net_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698